Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring CQRS structure for enhanced clarity and accessibility #205

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

tjementum
Copy link
Member

Summary & Motivation

Previously, Commands, Queries, Handlers, and Validators were nested within a static class named after the command or query. For instance, the CreateTenantCommand static class included nested Command, Handler, and Validator classes. This approach, while structured, led to references like CreateTenant.Command in the API, which received multiple remarks for its complexity and readability.

Addressing these concerns, the nested classes have now been elevated to the top level and renamed accordingly. For example, what was previously CreateTenant.Command is now CreateTenantCommand.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Nov 12, 2023
@tjementum tjementum self-assigned this Nov 12, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tjementum tjementum merged commit 035d524 into main Nov 12, 2023
7 checks passed
@tjementum tjementum deleted the remove-static-classes-for-command-and-queries branch November 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant